Back to the main page.

Bug 761 - test the ft_databrowser_new implementation

Status CLOSED FIXED
Reported 2011-06-14 13:02:00 +0200
Modified 2011-07-29 10:34:08 +0200
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P1 normal
Assigned to: Jörn M. Horschig
URL:
Tags:
Depends on:
Blocks:
See also:

Stephen Whitmarsh - 2011-06-14 13:02:01 +0200

I just tried it and 1) although some 'selection' by mouse click-and-drag occurs in the sense of bordering dotted lines appearing, the 'filling in' by a subsequent click, making it an event so that one can continue, doesn't work. 2) a vertical line at event trial onset (i guess start+offset when cfg.continious = 'no') doesnt appear yet. cheers, S


Jörn M. Horschig - 2011-06-16 22:24:14 +0200

thanks, I will check it asap - i.e. after the workshop tomorrow :)


Jörn M. Horschig - 2011-06-21 15:26:25 +0200

1) is fixed (I'll commit in a second) - the problem was that some plotting variables (hpos and width) were not stored in the figure data. I also had to rearrange some formulas (l. 636ff), they should be alright now. 2) I am not quite sure what you mean. Do you mean that no event is annotated with a vertical line? There should be quite many vertical lines, actually (for every trigger value, there should be one). Are you loading data from harddisk or using data from memory?


Jörn M. Horschig - 2011-06-29 10:54:59 +0200

- I fixed the event problem - the problem was the offset of the data was not taken into account (in code: opt.hlim(1) needed to be added to eventtim). So, Stephen, your problem is resolved now! - I fixed another problem which showed the wrong x-values in butterfly viewmode. XTickLabel was only set for "vertical" or "component" viewmode. - I will check further, therefore not closing this bug


Jörn M. Horschig - 2011-06-29 10:55:54 +0200

+ the tag is now also set for ft_plot_line (this was missing)


Jörn M. Horschig - 2011-06-30 09:41:40 +0200

I just tested the new implementation in component viewmode, removed two bugs and checked whether events and artifacts are annotated correctly. I think the function is ready to be made public and can be renamed to ft_databrowser


Jörn M. Horschig - 2011-07-14 15:55:28 +0200

svn-moved + mail sent to the list closing