Back to the main page.
Bug 74 - inconsistent use of cfg.eventfile and cfg.event
| Status | CLOSED FIXED |
| Reported | 2010-04-29 16:52:00 +0200 |
| Modified | 2011-01-26 15:38:32 +0100 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Mac OS |
| Importance: | P5 normal |
| Assigned to: | Tim Engelkes |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Robert Oostenveld - 2010-04-29 16:52:46 +0200
roboos@mentat001> grep cfg.eventfile *.m ft_databrowser.m:if ~isfield(cfg, 'eventfile'), cfg.eventfile = []; end ft_databrowser.m: if ~isempty(cfg.eventfile) ft_databrowser.m: event = ft_read_event(cfg.eventfile); roboos@mentat001> grep cfg.event *.m ft_definetrial.m:% cfg.event ft_definetrial.m: event = cfg.event; ft_definetrial.m:cfg.event = event; these functions use the cfg.eventfile and cfg.event inconsistently. If the user wants to specify events, then there should be one way. I suggest to change cfg.eventfile in databrowser into cfg.event, and let the user call cfg.event = ft_read_event(cfg.dataset); instead.
Robert Oostenveld - 2011-01-26 15:37:12 +0100
I closed all bugs that were resolved prior and including 2011-01-25. All resolved bugs should have been discussed by now, therefore we don't want to see them again in the next meeting. Instead, in the next meeting we want to see the recent improvements and fixes.