Back to the main page.
Bug 3256 - output of ft_componentanalysis should be timelock+comp when input is timelock
| Status | CLOSED FIXED |
| Reported | 2017-02-17 10:13:00 +0100 |
| Modified | 2019-08-10 12:41:06 +0200 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Mac OS |
| Importance: | P5 normal |
| Assigned to: | |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Robert Oostenveld - 2017-02-17 10:13:20 +0100
I noticed that ft_componentanalysis outputs raw+comp data, also when the input is timelock. It should be timelock+comp.
Robert Oostenveld - 2017-02-17 10:21:16 +0100
mac011> git commit -a [bug3256 bb7bd71] ENH - represent the output of ft_componentanalysis as timelock+comp when the input is timelock. See http://bugzilla.fieldtriptoolbox.org/show_bug.cgi?id=3256 5 files changed, 55 insertions(+), 5 deletions(-) create mode 100644 test/test_bug3256.m mac011> git push --set-upstream origin bug3256 Counting objects: 15, done. Delta compression using up to 4 threads. Compressing objects: 100% (15/15), done. Writing objects: 100% (15/15), 2.65 KiB | 0 bytes/s, done. Total 15 (delta 12), reused 0 (delta 0) remote: Resolving deltas: 100% (12/12), completed with 10 local objects. To github.com:robertoostenveld/fieldtrip.git * [new branch] bug3256 -> bug3256 Branch bug3256 set up to track remote branch bug3256 from origin. Since this potentially touches upon ft_datatype and other data conversions, I will first test it on a separate branch prior to merging it into master.
Robert Oostenveld - 2017-02-17 12:46:49 +0100
I tested, pulled and merged. See https://github.com/fieldtrip/fieldtrip/pull/337
Robert Oostenveld - 2019-08-10 12:34:55 +0200
This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on https://github.com/fieldtrip/fieldtrip/issues.