Back to the main page.

Bug 3175 - ft_hastoolbox('spm',1): SPM toolbox not installed

Status CLOSED FIXED
Reported 2016-08-19 18:48:00 +0200
Modified 2019-08-10 12:33:28 +0200
Product: FieldTrip
Component: external
Version: unspecified
Hardware: PC
Operating System: Mac OS
Importance: P5 normal
Assigned to: Arjen Stolk
URL:
Tags:
Depends on:
Blocks:
See also: http://bugzilla.fieldtriptoolbox.org/show_bug.cgi?id=3171

Arjen Stolk - 2016-08-19 18:48:50 +0200

>> ft_hastoolbox('spm',1) Error using ft_hastoolbox (line 450) the SPM toolbox is not installed whereas >> ft_hastoolbox('spm2',1) Warning: adding /Users/arjsto/Documents/MATLAB/fieldtrip/external/spm2 toolbox to your MATLAB path ans = 1 >> ft_hastoolbox('spm8',1) Warning: adding /Users/arjsto/Documents/MATLAB/fieldtrip/external/spm8 toolbox to your MATLAB path ans = 1 Most likely 'spm' not working is because there's no 'spm' folder in /external (unlike spm2 and spm8). A decision needs to be made on what to with these type of generalized requests (i.e. 'spm' without version ID), e.g. adding spm8, or the 'latest' somehow?


Robert Oostenveld - 2016-08-22 11:48:06 +0200

different SPM versions are not fully compatible and therefore I vote against using a generic "The SPM toolbox" label. Existing FT code distinguishes between SPM versions. Not all FT code will work properly with the latest SPM version, and we cannot use spm12 for everything. See also bug 3171. I suggest to keep it as it is. If you want to work on better integration anyway, I suggest to consider the existing FT code that depends on old SPM functions should be updated so that it also works with all later versions.


Arjen Stolk - 2016-08-23 06:44:17 +0200

(In reply to Robert Oostenveld from comment #1) Agreed. Note to myself: ensure alignctf2spm adds spm8 instead of spm.


Arjen Stolk - 2016-09-13 07:08:00 +0200

see https://github.com/fieldtrip/fieldtrip/pull/217


Robert Oostenveld - 2019-08-10 12:33:28 +0200

This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on https://github.com/fieldtrip/fieldtrip/issues.