Back to the main page.

Bug 3123 - ft_databrowser keyboard command queue is erratic

Status CLOSED FIXED
Reported 2016-05-09 20:55:00 +0200
Modified 2019-08-10 12:32:25 +0200
Product: FieldTrip
Component: plotting
Version: unspecified
Hardware: PC
Operating System: Mac OS
Importance: P5 normal
Assigned to: Roemer van der Meij
URL:
Tags:
Depends on:
Blocks: 2314
See also:

Roemer van der Meij - 2016-05-09 20:55:34 +0200

E.g., I'm flipping through trials while adjusting the y-scaling to see something a little better, and suddenly the scaling reverts to what it was a couple of trials ago, or it flips to trial 10-trials back. It seems this is actually stupidly easy to fix. Currently, the figure property Interruptible is on. This allows callbacks to be executed regardless of whether another callback is being executed. This allows key presses to be executed while the browser is still busy processing the previous command. For example, a y-scaling command can then adjust the scaling using the plotting data of the previous trial, saving it into the figure, while the browser is still busy processing the previous move-trial command. And vice versa. When a redraw takes a second or two, this can easily result in like 10 commands being attempted to execute simultaneously. By setting the property to off, and by keeping the BusyAction property at 'queue' (the default), this no longer happens. Callbacks are only run sequentially. Checking with a previous matlab and pull requesting.


Roemer van der Meij - 2016-05-09 21:02:12 +0200

Pull requested. This had been annoying since forever about the browser, happy to see it's so easy to fix.


Roemer van der Meij - 2016-05-11 22:29:21 +0200

*** Bug 2335 has been marked as a duplicate of this bug. ***


Robert Oostenveld - 2019-08-10 12:32:25 +0200

This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on https://github.com/fieldtrip/fieldtrip/issues.