Back to the main page.

Bug 3009 - pnt/pos renaming in ft_average_sens breaks SPM functionality

Status CLOSED FIXED
Reported 2015-11-23 15:04:00 +0100
Modified 2019-08-10 12:31:14 +0200
Product: FieldTrip
Component: forward
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P5 critical
Assigned to:
URL:
Tags:
Depends on:
Blocks:
See also: http://bugzilla.fieldtriptoolbox.org/show_bug.cgi?id=3017

Vladimir Litvak - 2015-11-23 15:04:01 +0100

ft_average_sens crashes now in SPM when averaging fiducials which still have a .pnt field (and will probably keep it in the near future). Here it's not sufficient to fix the input but the output should also be converted back to .pnt to make the change transparent. I reverted to previous version of the function in SPM for now. Vladimir


Robert Oostenveld - 2015-11-23 16:25:53 +0100

I don't have an overview of all functions that now output structures that contain pos instead of pnt, but ft_average_sens won't be the only one. If you don't want to change SPM, I suggest you stick to an old FT version or that you make a fixpnt function that does the same (but the other way) as fixpos does (see fieldtrip/private).


Vladimir Litvak - 2015-11-24 12:55:20 +0100

(In reply to Robert Oostenveld from comment #1) This is not so transparent any more then. In any case you should do a fix for the input and I'll do for the output. Currently it crashes inside the function. Vladimir


Vladimir Litvak - 2015-12-01 15:34:20 +0100

(In reply to Vladimir Litvak from comment #2) Hi Robert, Are you planning to fix this soon? Guillaume wants to release an SPM update soon and we'd like to include the fix in it. For now I reverted to the old version of the function. Thanks, Vladimir


Vladimir Litvak - 2015-12-03 12:59:23 +0100

OK, I despaired of waiting and fixed it myself. Please check. Vladimir


Robert Oostenveld - 2019-08-10 12:31:14 +0200

This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on https://github.com/fieldtrip/fieldtrip/issues.