Back to the main page.

Bug 2854 - beamformer_dics: fields in output are row vector rather than column

Status CLOSED FIXED
Reported 2015-02-23 16:09:00 +0100
Modified 2015-07-15 13:31:22 +0200
Product: FieldTrip
Component: inverse
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P5 normal
Assigned to: Jan-Mathijs Schoffelen
URL:
Tags:
Depends on:
Blocks:
See also:

Jan-Mathijs Schoffelen - 2015-02-23 16:09:05 +0100

ft_sourceanalysis with 'dics' currently outputs the numeric fields as a row-vector rather than a column-vector (how it used to be). I would be in favor of keeping it a column, because that would be consistent with the first dimension always being pos, rather than being ill-defined.


Jan-Mathijs Schoffelen - 2015-02-23 16:11:52 +0100

This probably affects other inverse-functions as well. ------------------------------------------------------------------------ r10250 | jansch | 2015-02-23 16:10:51 +0100 (Mon, 23 Feb 2015) | 1 line enhancement - output the numeric fields as column array ------------------------------------------------------------------------ Who's up for checking and adjusting this in the other functions?


Jan-Mathijs Schoffelen - 2015-02-23 16:12:44 +0100

@Nietzsche: note that this issue relates to the problem you encountered last week, where our code assumed the output to be column.


Jan-Mathijs Schoffelen - 2015-03-09 09:43:37 +0100

[jansch@mentat002 inverse]$ svn commit -m "enhancement - output the numeric fields as column array" beamformer_pcc.m Sending beamformer_pcc.m Transmitting file data . Committed revision 10270.


Jan-Mathijs Schoffelen - 2015-03-11 09:35:12 +0100

[jansch@mentat002 fieldtrip]$ svn commit -m "enhancement - output the numeric fields as column array" inverse/beamformer_lcmv.m Sending inverse/beamformer_lcmv.m Transmitting file data . Committed revision 10273.


Jan-Mathijs Schoffelen - 2015-07-03 12:29:05 +0200

As far as I can see, this seems to work well now. Reopen if needed.