Back to the main page.

Bug 2731 - ft_preproc_bandstopfilter - Number of input arguments

Status CLOSED INVALID
Reported 2014-10-10 14:57:00 +0200
Modified 2019-08-10 12:28:24 +0200
Product: FieldTrip
Component: core
Version: unspecified
Hardware: All
Operating System: Linux
Importance: P5 major
Assigned to:
URL:
Tags:
Depends on:
Blocks:
See also:

Giorgos Michalareas - 2014-10-10 14:57:04 +0200


Giorgos Michalareas - 2014-10-10 15:00:51 +0200

I run cfg = []; cfg.detrend = 'no'; cfg.bsfilter = 'yes'; cfg.bsfreq = [59 61]; data2 = ft_preprocessing(cfg, data1); ft_preprocessing calls /private/preproc.m which in line 323 does: dat = ft_preproc_bandstopfilter(dat, fsample, cfg.bsfreq(i,:), cfg.bsfiltord, cfg.bsfilttype, cfg.bsfiltdir, cfg.bsinstabilityfix, cfg.bsfiltdf, cfg.bsfiltwintype, cfg.bsfiltdev, cfg.plotfiltresp); These are 11 input arguments . I get an error because in ft_preproc_bandstopfilter.m : function [filt] = ft_preproc_bandstopfilter(dat,Fs,Fbp,N,type,dir,instabilityfix) has 7 input arguments. Any ideas?


Robert Oostenveld - 2014-10-10 16:59:40 +0200

the specific change in private/preproc.m is due to Eelke in r9685 Looking at https://code.google.com/p/fieldtrip/source/detail?r=9685 and specifically https://code.google.com/p/fieldtrip/source/browse/trunk/preproc/ft_preproc_bandpassfilter.m?spec=svn9685&r=9685 I see that the options are there in the code (but not documented). Also in my current version of the code the options are there. I guess that your version of fieldtrip is borked. In case it is a shared version of fieldtrip on your network drive: that has happened before at the ESI. Back then (~6 monhts ago) some files on your shared drive had simply not been updated, whereas others had moved on. Let me CC Kai on this.


Kai Roennburg - 2014-10-10 17:26:45 +0200

our cluster verison seems fine to me, I see 11 options. Will check our svn anyhow. ESI-svFShps-1# less ft_preproc_bandstopfilter.m function [filt] = ft_preproc_bandstopfilter(dat,Fs,Fbp,N,type,dir,instabilityfix,df,wintype,dev,plotfiltresp) public@esi-svhpc1:/opt/fieldtrip/preproc$ svn info Path: . URL: http://fieldtrip.googlecode.com/svn/trunk/preproc Repository Root: http://fieldtrip.googlecode.com/svn Repository UUID: dd5c34e0-11cd-11df-96c7-376cde75ada7 Revision: 9840 Node Kind: directory Schedule: normal Last Changed Author: roboos Last Changed Rev: 9825 Last Changed Date: 2014-09-22 17:19:53 +0200 (Mon, 22 Sep 2014)


Giorgos Michalareas - 2014-10-10 17:29:44 +0200

OOPs my fault sorry, my chron job for updating fieldtrip was stopped for some reason for a 2 weeks or something . I thought it had been updated. Now I did it manually and it has 11 input arguments. Sorry for that. Giorgos


Giorgos Michalareas - 2014-10-10 17:30:55 +0200

I am closing this issue.


Robert Oostenveld - 2019-08-10 12:28:24 +0200

This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue describing the issue on https://github.com/fieldtrip/fieldtrip/issues.