Back to the main page.
Bug 2517 - merge ft_checkdata/fixsource with ft_datatype_source
| Status |
ASSIGNED |
| Reported |
2014-04-01 23:38:00 +0200 |
| Modified |
2015-02-11 10:43:02 +0100 |
| Product: |
FieldTrip |
| Component: |
core |
| Version: |
unspecified |
| Hardware: |
PC |
| Operating System: |
Mac OS |
| Importance: |
P5 normal |
| Assigned to: |
Robert Oostenveld |
| URL: |
|
| Tags: |
|
| Depends on: |
|
| Blocks: |
|
| See also: |
http://bugzilla.fcdonders.nl/show_bug.cgi?id=2185 |
Robert Oostenveld - 2014-04-01 23:38:37 +0200
I noticed while working on bug #2185 that there is a discrepancy of what code is located where. The fixXXX stuff is still scattered, which is especially annoying for moving forward with the new source representation.
I suggest to move all functionality from the sub function fixsource in ft_checkdata to the ft_datatype_source function.
I also noticed that dimord is listed as required field in ft_datatype_source, although not a single function will presently fail if it is absent. So it does not seem to be strongly required, but rather optional. Note that in converting old to new style, it will be difficult to assign a single dominant dimord, but easy to assign the specific powdimord etc.
See test_bug2185 for some code to get started.
I also suggest to make a test with a for loop over all possible source data structures resulting from our historical test runs (i.e. common/matlab/fieldtrip/yyyymmdd).