Back to the main page.

Bug 2358 - ft_prepare_sourcemodel has a non-standard way of dealing with the input arguments

Status NEW
Reported 2013-11-01 11:01:00 +0100
Modified 2013-11-01 11:01:52 +0100
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Mac OS
Importance: P3 normal
Assigned to:
URL:
Tags:
Depends on:
Blocks:
See also:

Robert Oostenveld - 2013-11-01 11:01:08 +0100

somewhere at the top it has if ~isfield(cfg, 'vol') && nargin>1 % put it in the configuration structure % this is for backward compatibility, 13 Januari 2011 cfg.vol = vol; end if ~isfield(cfg, 'grad') && ~isfield(cfg, 'elec') && nargin>2 % put it in the configuration structure % this is for backward compatibility, 13 Januari 2011 cfg.grad = sens; end and further down it states if ischar(cfg.mri) mri = ft_read_mri(cfg.mri); else mri = cfg.mri; end dealing with the sens/vol/mri should be made consistent. Probably the mri is the most obscure, and the old vol/sens support can just be removed. The basedonmri section should be reconsidered, or perhaps removed completely. I don't think it has been used in the last 5 years by anyone.


Robert Oostenveld - 2013-11-01 11:01:52 +0100

please note that I am presently working on it in relation to bug #2355, so don't make any changes today to avoid conflicts!