Back to the main page.
Bug 2128 - ft_provenance cfg.trackcallinfo vs. ft_default.trackcallinfo
| Status | CLOSED DUPLICATE |
| Reported | 2013-04-19 14:51:00 +0200 |
| Modified | 2019-08-10 12:04:00 +0200 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Windows |
| Importance: | P3 normal |
| Assigned to: | |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Jörn M. Horschig - 2013-04-19 14:51:53 +0200
I realized that in ft_preamble_provenance, it is only checked for cfg.trackcallinfo: global ft_default if isfield(cfg, 'trackcallinfo') && ~istrue(cfg.trackcallinfo) % do not track the call information return end imho a global setting, i.e. ft_default.trackcallinfo should be checked as well, where cfg.trackcallinfo (i.e. a local setting) can overrule the global setting, thus these lines might be better: if isfield(cfg, 'trackcallinfo') if ~istrue(cfg.trackcallinfo) return end elseif ~istrue(ft_default.trackcallinfo) return end alternatively, in one call: if (isfield(cfg, 'trackcallinfo') && ~istrue(cfg.trackcallinfo)) || ... (~isfield(cfg, 'trackcallinfo') && ~istrue(ft_default.trackcallinfo)) return; end the involvement of trackdatainfo might be relevant here as well, because ft_preamble_provenance actually handles the data as well (md5 hash)
Roemer van der Meij - 2013-04-19 16:27:44 +0200
We've been discussing exactly this in bug 1987 :) *** This bug has been marked as a duplicate of bug 1987 ***