Back to the main page.

Bug 193 - deprecate cfg.sourceunits and cfg.mriunits

Status CLOSED FIXED
Reported 2010-10-27 08:43:00 +0200
Modified 2011-06-22 14:19:05 +0200
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: All
Importance: P1 normal
Assigned to: Jan-Mathijs Schoffelen
URL:
Tags:
Depends on:
Blocks:
See also:

Robert Oostenveld - 2010-10-27 08:43:20 +0200

In the past sourceunits and mriunits were not known from thedata and therefore had to be specified by the user in these cfg fields. However, nowadays the geometrical objects contain a field units (or ft_convert_units can be used to generate one). So these options should not be needed any more. The only exception that I can think of is ft_prepare_headmodel a.k.a. volume conduction model (bemmodel/singlesphere/multisphere/concentricsphere), in which the units of the output model have to be specifiable (by using cfg.sourceunits). cfg.mriunits and cfg.sourceunits have to be deprecated in the code. It has to be checked that all functions working with anatomical geometries use ft_convert_units. Furthermore, the reference documentation has to be updated.


Jan-Mathijs Schoffelen - 2011-06-15 17:21:21 +0200

I deprecated mriunits throughout the code. I kept sourceunits to be specifiable in ft_prepare_headmodel (and ft_prepare_localspheres/singleshell)