Back to the main page.

Bug 1483 - dimord 'rpt' not yet allowed in ft_selectdata_new

Reported 2012-05-18 12:48:00 +0200
Modified 2014-01-15 14:42:52 +0100
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P3 normal
Assigned to: Jan-Mathijs Schoffelen
Depends on:
See also:

Johanna - 2012-05-18 12:48:47 +0200

I know there are still many 'FIXME's in ft_selectdata_new, but I often have 'rpt' as dimension in my data, and as of now this is not allowed in ft_selectdata_new, even if not selecting over that dimension (i.e. if instead selecting over time or freq). I know there are many other open bugs on ft_selectdata* (e.g. bug 1021) but just thought I'd make this detail explicit.

Jan-Mathijs Schoffelen - 2012-06-08 16:38:13 +0200

generated test script bug confirmed in general -> ft_selectdata_new crashes with raw data in the input -> but irrespective of the datatyp there's an error('FIXME') statement for many requested selections

Jan-Mathijs Schoffelen - 2012-06-08 16:39:56 +0200

but I see that Johanna already noticed this too ;-)

Jörn M. Horschig - 2013-02-14 10:48:57 +0100

this works now, right?

Jörn M. Horschig - 2013-02-14 10:50:49 +0100

btw, I made rpttap work as well, please check some day whether this is alright

Johanna - 2013-06-10 10:15:34 +0200

I add this here rather than a new bug, as it's related. ft_selectdata_new does not work with 'avgoverrpt' (tested on 'freq' data, with dimord 'rpt_chan_freq_time'). If cfg.trials is not specified, then 'selrpt' is NaN on line 251. This means line 263 is never executed and neither selection nor averaging over rpt occurs. If cfg.trials is specified, then the selection and averaging over trials does occur, and the .dimord is appropriately updated to 'chan_freq_time' but the size of the .powspctrm is still 1xCxFxT. It seems this needs fixing also for timelock and source data.

Jan-Mathijs Schoffelen - 2013-10-29 15:22:21 +0100

tested, fixed, and tested for frequency domain data. -avgoverrpt should now work -selection of trials should now work (including tapers in the case of fourierspctrm) TO DO: check the other data types

Jan-Mathijs Schoffelen - 2013-11-28 12:23:50 +0100

implemented it for timelock data in ft_selectdata_new. implemented it for raw data a while ago. closing for now.