Back to the main page.

Bug 1079 - the cfg parsing of ft_multiplotTFR fails

Status CLOSED FIXED
Reported 2011-10-26 15:45:00 +0200
Modified 2011-11-02 14:32:08 +0100
Product: FieldTrip
Component: plotting
Version: unspecified
Hardware: PC
Operating System: Mac OS
Importance: P1 normal
Assigned to: Jan-Mathijs Schoffelen
URL:
Tags:
Depends on:
Blocks:
See also:

Robert Oostenveld - 2011-10-26 15:45:42 +0200

ft_multiplotTFR contains the following, which won't work according to me... ?? % Set the defaults: cfg = ft_getopt(cfg, 'baseline', 'no'); cfg = ft_getopt(cfg, 'baselinetype', 'absolute'); cfg = ft_getopt(cfg, 'trials', 'all'); cfg = ft_getopt(cfg, 'xlim', 'maxmin'); cfg = ft_getopt(cfg, 'ylim', 'maxmin'); cfg = ft_getopt(cfg, 'zlim', 'maxmin'); ... see also bug 1074


Robert Oostenveld - 2011-10-26 15:46:49 +0200

please also fix the following: ft_movieplotTFR does the following, which means that the cfg defaults are not updated % set the defaults xlim = ft_getopt(cfg, 'xlim', 'maxmin'); ylim = ft_getopt(cfg, 'ylim', 'maxmin'); zlim = ft_getopt(cfg, 'zlim', 'maxmin'); xparam = ft_getopt(cfg, 'xparam','time'); yparam = ft_getopt(cfg, 'yparam'); % default is dealt with below parameter = ft_getopt(cfg, 'parameter', 'powspctrm'); % use power as default inputfile = ft_getopt(cfg, 'inputfile', []); samperframe = ft_getopt(cfg, 'samperframe', 1); framespersec = ft_getopt(cfg, 'framespersec', 5); framesfile = ft_getopt(cfg, 'framesfile', []); moviefreq = ft_getopt(cfg, 'moviefreq', []); movietime = ft_getopt(cfg, 'movietime', []); movierpt = ft_getopt(cfg, 'movierpt', 1); interactive = ft_getopt(cfg, 'interactive', 'yes'); ...


Jan-Mathijs Schoffelen - 2011-10-26 15:50:32 +0200

fixed at revision 4599 for ft_multiplotTFR


Jan-Mathijs Schoffelen - 2011-10-26 16:02:21 +0200

Actually ft_movieplotTFR updates the cfg later on in the function; I'll change the code around a bit, so that the call to ft_getopt directly changes the cfg


Jan-Mathijs Schoffelen - 2011-10-26 16:21:08 +0200

Also, actually, ft_movieplotTFR does not produce an output, so it is not absolutely necessary to have the cfg updated -> as long as the options are passed on correctly to the guidata. Change was however incorporated in revision 4600 (tested with test_ft_movieplotTFR, this still runs through)